Skip to content

Conversation

emiride
Copy link
Contributor

@emiride emiride commented Aug 29, 2025

Description

This PR establishes basic structure and working version of Playwright tests.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #2883

Description of Changes

Added functionality to connect to existing browser.

Breaking Changes

No breaking changes.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

emiride and others added 3 commits August 25, 2025 13:01
* test(cat-voices): add semantic ids for tests

* test(cat-voices): minor additional changes

* chore(cat-voices): upgrade flutter to 3.32.8 (#3195)

* chore: point to branch-based ci version

* chore: upgrade flutter 3.32.8, dart 3.8.0, gradle wrapper to 8.4

* chore: address deprecated code after flutter upgrade

* chore: upgrade flutter_rust_bridge to 2.11.1

* chore: upgrade dependencies

* chore: let analyzer be transitive dependency

* chore: migrate deprecated API

* chore: remove unused viewport flag

* chore: regenerate flutter_rust_bridge entry point

* chore: downgrade go_router to fix dependency resolution

* chore: upgrade dependencies, remove unused ones

* chore: preserve trailing commas

* chore: disable code-format check

* chore: commit files coming from the new flutter version

* chore: install pods

* fix: tests

* chore: address discarded futures lint

* fix: license list generator

* fix: discarded future

* fix: discarded futures

* chore: dart doc upgrade

* chore: document workarounds

* chore: use tagged ci version

* chore: cleanup

* chore: spelling

* fix: await discarded future

* chore: allow MPL-2.0 license

* test(cat-voices): add semantic tags fir tests

* fix: conflicts

* chore: cleanup

* test(cat-voices): add semantic ids on latest Flutter

* test(cat-voices): fix formatting

* test(cat-voices): fix formatting

* test(cat-voices): fixes based on pr comments

* test(cat-voices): fixes based on pr comments

* test(cat-voices): latest fixes based on pr comments

---------

Co-authored-by: Dominik Toton <[email protected]>
Co-authored-by: Ryszard Schossler <[email protected]>
Co-authored-by: Dominik Toton <[email protected]>
* test(cat-voices): add semantic ids for tests

* test(cat-voices): minor additional changes

* chore(cat-voices): upgrade flutter to 3.32.8 (#3195)

* chore: point to branch-based ci version

* chore: upgrade flutter 3.32.8, dart 3.8.0, gradle wrapper to 8.4

* chore: address deprecated code after flutter upgrade

* chore: upgrade flutter_rust_bridge to 2.11.1

* chore: upgrade dependencies

* chore: let analyzer be transitive dependency

* chore: migrate deprecated API

* chore: remove unused viewport flag

* chore: regenerate flutter_rust_bridge entry point

* chore: downgrade go_router to fix dependency resolution

* chore: upgrade dependencies, remove unused ones

* chore: preserve trailing commas

* chore: disable code-format check

* chore: commit files coming from the new flutter version

* chore: install pods

* fix: tests

* chore: address discarded futures lint

* fix: license list generator

* fix: discarded future

* fix: discarded futures

* chore: dart doc upgrade

* chore: document workarounds

* chore: use tagged ci version

* chore: cleanup

* chore: spelling

* fix: await discarded future

* chore: allow MPL-2.0 license

* test(cat-voices): add semantic tags fir tests

* chore: cleanup

* chore: cleanup

* feat: add semantics

* chore: restore code

* chore: spelling

* fix: conflicts

* chore: cleanup

* chore: reformat code

* test(cat-voices): add semantic ids on latest Flutter

* test(cat-voices): fix formatting

* test(cat-voices): fix formatting

* chore: cleanup

* chore: cleanup

---------

Co-authored-by: emiride <[email protected]>
Co-authored-by: Ryszard Schossler <[email protected]>
# Conflicts:
#	catalyst_voices/apps/voices/lib/widgets/containers/sidebar/space_side_panel.dart
@emiride emiride force-pushed the playwright-setup-v2 branch from 6cd9554 to 45296be Compare August 29, 2025 09:44
@emiride emiride added the squad: face Frontend Catalyst Experience Team label Aug 29, 2025
@emiride emiride moved this from New to 🔖 Ready in Catalyst Aug 29, 2025
@emiride emiride moved this from 🔖 Ready to 👀 In review in Catalyst Aug 29, 2025
@emiride emiride requested a review from kukkok3 August 29, 2025 10:00
@emiride emiride linked an issue Aug 29, 2025 that may be closed by this pull request
@emiride emiride marked this pull request as ready for review August 29, 2025 10:03
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just that comment about the localhost

@emiride emiride requested a review from kukkok3 September 1, 2025 09:42
kukkok3
kukkok3 previously approved these changes Sep 1, 2025
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emiride emiride force-pushed the playwright-setup-v2 branch 4 times, most recently from 475bc64 to 69f6187 Compare September 1, 2025 13:05
@emiride emiride force-pushed the playwright-setup-v2 branch from 69f6187 to bc831ba Compare September 1, 2025 13:38
@emiride emiride force-pushed the playwright-setup-v2 branch from ea038f0 to fe05cb0 Compare September 2, 2025 03:33
@emiride emiride linked an issue Sep 2, 2025 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Sep 2, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/voices/playwright-setup-v2

damian-molinski
damian-molinski previously approved these changes Sep 2, 2025
Base automatically changed from e2e-and-integration-tests to main September 10, 2025 09:53
@emiride emiride dismissed stale reviews from damian-molinski and kukkok3 September 10, 2025 09:53

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: face Frontend Catalyst Experience Team
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add README to e2e tests 🛠️ [TASK] : Create basic Playwright setup
4 participants