-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): documents campaign isolation #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damian-molinski
wants to merge
23
commits into
f15/cat-app
Choose a base branch
from
feat/documents_campaign_isolation_316
base: f15/cat-app
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(cat-voices): documents campaign isolation #3462
damian-molinski
wants to merge
23
commits into
f15/cat-app
from
feat/documents_campaign_isolation_316
+1,250
−598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LynxLynxx
reviewed
Sep 24, 2025
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposals/proposals_cubit.dart
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Sep 25, 2025
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/campaign/campaign.dart
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Sep 25, 2025
...nternal/catalyst_voices_models/lib/src/campaign/constant/f14_static_campaign_categories.dart
Outdated
Show resolved
Hide resolved
dt-iohk
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/documents_campaign_isolation_316 |
dt-iohk
approved these changes
Sep 25, 2025
Waiting for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: proposal
Showing proposals or details of single proposal
no-track
Used to skip tracking in Swarmia analytics, etc.
squad: face
Frontend Catalyst Experience Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares frontend for changing active campaigns
Related Issue(s)
Resolves https://github.com/input-output-hk/catalyst-internal-docs/issues/316
Description of Changes
AppMetaStorage
). When changes database documents are removes but templates used by local drafts. This happens insideSyncManager
.campaign
shown in workspace inside separate section withview
only option.CampaignFilters
. This is not as dynamic as it should be but for now it's enough.campaign
does not have any categories.f15
constructor for campaign.Demo
TODO
Related Pull Requests
v1/document/index
endpointid
field #3446Please confirm the following checks