feat(cat-voices): new datasource of proposal data #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LynxLynxx
added
review me
LynxLynxx
changed the title
…catalyst-voices into feat/proposal-viewer-v2
LynxLynxx
requested review from
bstolinski,
damian-molinski and
dt-iohk
as code owners
damian-molinski
requested changes
Dec 10, 2025
Contributor
damian-molinski
left a comment
damian-molinski
left a comment
There was a problem hiding this comment.
I'll review tests after those updates
...ckages/internal/catalyst_voices_models/lib/src/proposal/data/proposal_data_collaborator.dart
Outdated
Show resolved
Hide resolved
..._voices/packages/internal/catalyst_voices_models/lib/src/proposal/data/proposal_data_v2.dart
Outdated
Show resolved
Hide resolved
...ckages/internal/catalyst_voices_models/lib/src/proposal/data/proposal_data_collaborator.dart
Outdated
Show resolved
Hide resolved
...es/packages/internal/catalyst_voices_repositories/lib/src/database/dao/documents_v2_dao.dart
Outdated
Show resolved
Hide resolved
...es/packages/internal/catalyst_voices_repositories/lib/src/database/dao/proposals_v2_dao.dart
Outdated
Show resolved
Hide resolved
...es/packages/internal/catalyst_voices_repositories/lib/src/database/dao/proposals_v2_dao.dart
Outdated
Show resolved
Hide resolved
...nal/catalyst_voices_repositories/lib/src/document/source/database_documents_data_source.dart
Show resolved
Hide resolved
...ces/packages/internal/catalyst_voices_repositories/lib/src/proposal/proposal_repository.dart
Outdated
Show resolved
Hide resolved
…catalyst-voices into feat/proposal-viewer-v2
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/proposal-viewer-v2 |
Contributor
damian-molinski
left a comment
damian-molinski
left a comment
There was a problem hiding this comment.
Few minor comments, other then that LGTM
...ages/internal/catalyst_voices_models/test/proposal/data/proposal_data_collaborator_test.dart
Show resolved
Hide resolved
...es/packages/internal/catalyst_voices_repositories/lib/src/database/dao/proposals_v2_dao.dart
Show resolved
Hide resolved
...atalyst_voices_repositories/lib/src/document/source/proposal_document_data_local_source.dart
Outdated
Show resolved
Hide resolved
Comment on lines
562
to
569
| ProposalDocument? proposalDocument; | ||
| if (templateData != null) { | ||
| final template = ProposalTemplateFactory.create(templateData); | ||
| proposalDocument = ProposalDocumentFactory.create( | ||
| rawProposal.proposal, | ||
| template: template, | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
don't get it. Why do you do this when there is already proposalOrDocument above?
Contributor
Author
There was a problem hiding this comment.
Because ProposalDocumentFactory is only accessable in repository package so we can't create a proposal doc in cubit. Or we need to export this factory so its ussable in bloc package
...kages/internal/catalyst_voices_repositories/test/src/database/dao/proposals_v2_dao_test.dart
Outdated
Show resolved
Hide resolved
Comment on lines
+595
to
+602
| expect( | ||
| actions.any( | ||
| (action) => | ||
| action.metadata.ref == proposal1Ref && | ||
| (action.metadata.authors?.contains(author1) ?? false), | ||
| ), | ||
| isTrue, | ||
| ); |
Contributor
There was a problem hiding this comment.
It should check if there are any actions from other authors then author1 and refer is different from proposal1Ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR only sets data source for getting proposal data with all needed information to use it in
ProposalViewerandProposalBuilder. In seprate PRProposalCubitwill start usingProposalDataV2as I still not map all of the data required by this model.Related Issue(s)
Part of #3767
Closes #3836
Please confirm the following checks