-
Notifications
You must be signed in to change notification settings - Fork 2
feat(athena): shared types and functions #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this "shared" 🚀
shared::bindings_generate!({ | ||
world: "hermes:app/hermes", | ||
path: "../../../wasi/wit", | ||
path: "../../../../../wasm/wasi/wit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention it here, for earthly to work I need path: "../../../wasi/wit",
but for local dev I need path: "../../../../../wasm/wasi/wit"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
Related Issue(s)
Description of Changes
Added a workspace Cargo.toml for Athena (otherwise the lints didn't work on me)
Moved utils and some database mods from rbac-registration to shared crate
Added a wrapper macro for wit-bindgen to share the bindings concisely
disable_custom_section_link_helpers: true
.Refactored Athena src to
use
shared rather thanwit-bindgen
bindings, as well as shared utilitiesFixed some of the clippy lints (e.g. added
let _ =
for some unused results). Maintaining the current behaviour.Breaking Changes
Some rust mods and functions moved to
shared
.Screenshots
Related Pull Requests
Please confirm the following checks