Skip to content

Conversation

no30bit
Copy link
Contributor

@no30bit no30bit commented Sep 23, 2025

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

Description of Changes

  • Added a workspace Cargo.toml for Athena (otherwise the lints didn't work on me)

  • Moved utils and some database mods from rbac-registration to shared crate

  • Added a wrapper macro for wit-bindgen to share the bindings concisely

    • Notably, now configured to disable_custom_section_link_helpers: true.
  • Refactored Athena src to use shared rather than wit-bindgen bindings, as well as shared utilities

  • Fixed some of the clippy lints (e.g. added let _ = for some unused results). Maintaining the current behaviour.

Breaking Changes

Some rust mods and functions moved to shared.

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@no30bit no30bit self-assigned this Sep 23, 2025
@no30bit no30bit added the enhancement New feature or request label Sep 23, 2025
@no30bit no30bit requested a review from stevenj as a code owner September 23, 2025 21:25
@no30bit no30bit added the review me PR is ready for review label Sep 23, 2025
@no30bit no30bit added the squad: hermetics Hermes Backend, System Development & Integration Team label Sep 23, 2025
@no30bit no30bit requested a review from aido-mth as a code owner September 23, 2025 21:25
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this "shared" 🚀

shared::bindings_generate!({
world: "hermes:app/hermes",
path: "../../../wasi/wit",
path: "../../../../../wasm/wasi/wit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention it here, for earthly to work I need path: "../../../wasi/wit", but for local dev I need path: "../../../../../wasm/wasi/wit"

@no30bit no30bit added this to Catalyst Sep 24, 2025
@no30bit no30bit moved this from New to 👀 In review in Catalyst Sep 24, 2025
aido-mth
aido-mth previously approved these changes Sep 24, 2025
Copy link
Contributor

@aido-mth aido-mth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review squad: hermetics Hermes Backend, System Development & Integration Team
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants