Set libblst .version to match Cargo.toml
#603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative would have been to set the version only in the `.pc` file based on `Cargo.toml`. However, the derivation’s `.version` must be accurate so that haskell.nix planning can detect it without building. Therefore, we hardcode `.version` in the derivation, and add a check against `Cargo.toml` to ensure it stays in sync.
hamishmack
added a commit
that referenced
this pull request
Sep 9, 2025
Haskell.nix expects the derivations `.version` and the version in the `.pc` file to match. This is a follow up to #603
hamishmack
added a commit
that referenced
this pull request
Sep 9, 2025
Haskell.nix expects the derivations `.version` and the version in the `.pc` file to match. This is a follow up to #603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative would have been to set the version only in the
.pcfile based onCargo.toml. However, the derivation’s.versionmust be accurate so that haskell.nix planning can detect it without building.Therefore, we hardcode
.versionin the derivation, and add a check againstCargo.tomlto ensure it stays in sync.