Skip to content

Make libsodium-vrf and secp256k1 .version match .pc file #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamishmack merged 1 commit into from
Sep 9, 2025
Merged

Make libsodium-vrf and secp256k1 .version match .pc file #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion overlays/crypto/libsecp256k1.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

stdenv.mkDerivation rec {
pname = "secp256k1";
version = src.shortRev;
version = "0.3.2";

inherit src;

Expand All @@ -18,6 +18,20 @@ stdenv.mkDerivation rec {

doCheck = true;

# Verify .pc version matches derivation version
preCheck = ''
pc_file="libsecp256k1.pc"
if [ ! -f "$pc_file" ]; then
echo "ERROR: pkg-config file not found: $pc_file"
exit 1
fi
pc_version=$(sed -n 's/^Version: *//p' "$pc_file")
if [ "$pc_version" != "${version}" ]; then
echo "ERROR: Version mismatch: derivation has ${version}, but .pc file has $pc_version"
exit 1
fi
'';

meta = with lib; {
description = "Optimized C library for EC operations on curve secp256k1";
longDescription = ''
Expand Down
16 changes: 15 additions & 1 deletion overlays/crypto/libsodium.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

stdenv.mkDerivation rec {
pname = "libsodium-vrf";
version = src.shortRev;
version = "1.0.18";

inherit src;

Expand All @@ -21,6 +21,20 @@ stdenv.mkDerivation rec {

doCheck = true;

# Verify .pc version matches derivation version
preCheck = ''
pc_file="libsodium.pc"
if [ ! -f "$pc_file" ]; then
echo "ERROR: pkg-config file not found: $pc_file"
exit 1
fi
pc_version=$(sed -n 's/^Version: *//p' "$pc_file")
if [ "$pc_version" != "${version}" ]; then
echo "ERROR: Version mismatch: derivation has ${version}, but .pc file has $pc_version"
exit 1
fi
'';

meta = with lib; {
description = "A modern and easy-to-use crypto library - VRF fork";
homepage = "http://doc.libsodium.org/";
Expand Down
Loading