CI: enhance nightly backward compatibility testing workflow #2083
+143
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: DJO <[email protected]> Co-authored-by: Jean-Philippe Raynaud <[email protected]>
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
approved these changes
Nov 4, 2024
| || (echo "SUCCESS=false" >> $GITHUB_ENV && exit 1) | ||
|
|
||
| - name: Define the JSON file name for the test result | ||
| if: always() |
There was a problem hiding this comment.
Do you want this step to run even if the run is cancelled ? If yes keep it as is, else change it to:
Suggested change
| if: always() | |
| if: success() || failure() |
same remark for all steps with a if: always in the file
Causes the step to always execute, and returns true, even when canceled.
There was a problem hiding this comment.
Yes, this step must always run to upload the JSON result file indicating the failure. I'll make the modifications, thanks!
There was a problem hiding this comment.
Updated in this commit ✅ .
jpraynaud
approved these changes
Nov 4, 2024
| @@ -18,17 +19,42 @@ on: | |||
| default: "10.1.1" | |||
There was a problem hiding this comment.
Suggested change
| default: "10.1.1" | |
| default: "10.1.2" |
There was a problem hiding this comment.
Updated in this commit ✅ .
| run: | | ||
| if [[ "${{ github.event_name }}" == "schedule" ]]; then | ||
| echo "total_releases=3" >> $GITHUB_OUTPUT | ||
| echo 'cardano_node_version=["10.1.1"]' >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Suggested change
| echo 'cardano_node_version=["10.1.1"]' >> $GITHUB_OUTPUT | |
| echo 'cardano_node_version=["10.1.2"]' >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Updated in this commit ✅ .
dlachaume
force-pushed
the
ensemble/2027/enhance-nightly-backward-compatibility-testing-workflow
branch
from
f6e0eb7
to
17f8c3c
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes enhancements for the nightly backward compatibility testing workflow.
It schedules the workflow to run at night (2:30 UTC) and uploads artifacts upon failure.
Additionally, it introduces a comprehensive published summary for the runs:
Pre-submit checklist
Issue(s)
Closes #2027