Feat: add latest shortcut as targeted era for Cardano CLI commands
#2085
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
reviewed
Nov 4, 2024
| @@ -66,6 +66,7 @@ impl CardanoCliRunner { | |||
| fn command_for_utxo(&self, address: &str, out_file: PathBuf) -> Command { | |||
| let mut command = self.get_command(); | |||
| command | |||
| .arg("latest") | |||
There was a problem hiding this comment.
It's not obvious that this is the cardano era that is used, plus since it's used multiple times I think that you can add a LATEST_CARDANO_ERA static variable to encompass those concerns.
There was a problem hiding this comment.
You're right, I’ve addressed your comment in this commit.
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an update to the Cardano CLI calls by adding the
latestshortcut as a targeted era for Cardano CLI commands.Pre-submit checklist
Issue(s)
Closes #2072