Skip to content

Conversation

turmelclem
Copy link
Collaborator

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@turmelclem turmelclem changed the title Ctl/2692 decentralization of configuration parameters phase 1 Decentralization of configuration parameters phase 1 Sep 24, 2025
Copy link

github-actions bot commented Sep 24, 2025

Test Results

    4 files  ±  0    168 suites  +4   23m 46s ⏱️ -29s
2 208 tests + 26  2 208 ✅ + 26  0 💤 ±0  0 ❌ ±0 
6 813 runs  +104  6 813 ✅ +104  0 💤 ±0  0 ❌ ±0 

Results for commit 1779ca9. ± Comparison against base commit 22f438c.

This pull request removes 1 and adds 27 tests. Note that renamed tests count towards both.
mithril-signer ‑ runtime::runner::tests::test_inform_epoch_setting_pass_allowed_discriminant_to_epoch_service
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_ko_500
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_ko_json_serialization
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_ok_200
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_timeout
mithril-protocol-config ‑ http_client::aggregator_client::tests::epoch_settings::test_epoch_settings_ko_500
mithril-protocol-config ‑ http_client::aggregator_client::tests::epoch_settings::test_epoch_settings_ok_200
mithril-protocol-config ‑ http_client::aggregator_client::tests::epoch_settings::test_epoch_settings_timeout
mithril-protocol-config ‑ http_client::aggregator_client::tests::test_4xx_errors_are_handled_as_remote_server_logical
mithril-protocol-config ‑ http_client::aggregator_client::tests::test_550_error_is_handled_as_registration_round_not_yet_opened
mithril-protocol-config ‑ http_client::aggregator_client::tests::test_5xx_errors_are_handled_as_remote_server_technical
…

♻️ This comment has been updated with latest results.

@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from 43f79ef to b890de0 Compare September 24, 2025 14:36
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 3682084 to 910faf9 Compare September 30, 2025 13:00
@turmelclem turmelclem self-assigned this Sep 30, 2025
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 3 times, most recently from 0f0d971 to d4a42de Compare September 30, 2025 15:24
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 683fd96 to 73af399 Compare October 3, 2025 15:15
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from eeba9a7 to 1779ca9 Compare October 3, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants