refactor: replace unmaintained serde_yml dependency
#2711
+220
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'serde_yml' is unmaintained, archived and has security vulnerabilities.
…arsing So it's easier to change it, or maybe add another file format, if needed.
* mithril-build-script from `0.2.26` to `0.2.27` * mithril-api-spec from `0.1.6` to `0.1.7`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR replaces usages of the
serde_yamlcrate withsaphyras the former is now unmaintained.Note
saphyrhave yet to include a serde conversion layer, meaning a conversion layer was added when needed.Pre-submit checklist
Comments
There's a concern over the current state of the
saphyrlibrary, it's currently going on a unstable development phase where each version can include breaking changes.In the future the light yaml parsing layer in
mithril-api-specmay have to be changed multiple times in order to adapt to the lastsaphyrchanges.Issue(s)
Closes #2700