Skip to content

Decentralization of configuration parameters phase 1 - Aggregator local parameters #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Decentralization of configuration parameters phase 1 - Aggregator local parameters #2736

wants to merge 13 commits into from

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Oct 13, 2025

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #YYY or Closes #YYY

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 13, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Test Results

    4 files  ±0    168 suites  ±0   24m 31s ⏱️ + 1m 35s
2 211 tests +4  2 211 ✅ +4  0 💤 ±0  0 ❌ ±0 
6 895 runs  +8  6 895 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit de20459. ± Comparison against base commit 2ad7d5e.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both. 
mithril-aggregator ‑ database::query::epoch_settings::update_epoch_settings::tests::test_update_epoch_settings
mithril-aggregator ‑ runtime::runner::tests::test_update_epoch_settings
mithril-aggregator ‑ services::epoch_service::tests::update_epoch_settings_insert_future_epoch_settings_in_the_store

mithril-aggregator ‑ database::query::epoch_settings::insert_or_ignore_epoch_settings::tests::test_cant_replace_existing_value
mithril-aggregator ‑ database::query::epoch_settings::insert_or_ignore_epoch_settings::tests::test_insert_epoch_setting_in_empty_db
mithril-aggregator ‑ database::repository::epoch_settings_store::tests::save_epoch_settings_does_not_replace_existing_value_in_database
mithril-aggregator ‑ services::epoch_service::tests::inform_epoch_insert_registration_epoch_settings_in_the_store
mithril-aggregator ‑ services::network_configuration_provider::tests::get_stored_configuration_with_stored_value_returns_them
mithril-aggregator ‑ services::network_configuration_provider::tests::get_stored_configuration_without_stored_value_fallback_to_configuration_value
mithril-aggregator ‑ services::network_configuration_provider::tests::test_get_network_configuration_retrieve_configurations_for_aggregation_next_aggregation_and_registration

♻️ This comment has been updated with latest results.

@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch from 407ea74 to bc2e5d5 Compare October 29, 2025 15:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2025
View reviewed changes
@turmelclem turmelclem self-assigned this Oct 29, 2025
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch from 120452b to 4e21205 Compare November 3, 2025 16:02
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 3, 2025
View reviewed changes
@Alenar Alenar temporarily deployed to testing-preview November 5, 2025 09:01 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch from 1b74219 to 890ad0b Compare November 5, 2025 14:58
@Alenar Alenar temporarily deployed to testing-preview November 5, 2025 15:08 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch 4 times, most recently from 07d14a3 to 80abe55 Compare November 6, 2025 11:12
@Alenar Alenar temporarily deployed to testing-preview November 6, 2025 17:20 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch from 80abe55 to 6752f97 Compare November 7, 2025 13:59
turmelclem and others added 10 commits November 7, 2025 15:08
@turmelclem
feat(aggregator): implement local configuration for mithril network c…
b69115a 
…onfiguration and adapt epoch service
@turmelclem
chore(aggregator): remove update_epoch_settings from epoch_service, c…
76a1ea5 
…leanup dependency injection
@turmelclem
refactor(aggregator): do not override existing epoch settings on save
0b9abb2
@Alenar @turmelclem
feat(aggregator): add preload_security_parameter config parameter
7709907
@turmelclem
feat(aggregator): make protocol_parameters and cardano_transaction_si…
ada9659 
…gning_config optionnal (mandatory for leader)
@Alenar @turmelclem
test(aggregator): simplify & rework serve deps container test tooling
88b34c0 
Rework `init_state_from_fixture` to not save epoch_settings and works
with the fixed window of three epoch (aggregate/next aggregate/signer
registration), epoch settings should already exists, most of the time
they will be inserted by the handle discrepancies system
@Alenar @turmelclem
feat(aggregator): move & rework handle discrepancies
49db028 
- run it at the end of the serve dependency container build
- retrieve and save data from the network configuration provider instead
  of the local node configuration
- update follower integration test to check that local protocol
  parameter configuration is not read, instead the configuration is read
  through the network configuration provider from the leader
@Alenar @turmelclem
chore(aggregator): log when a dependency is built by the dep builder
4dc2107
@Alenar @turmelclem
fix(e2e): only update protocol parameters on leader aggregator
f18c990 
Since now the follower read the network config from the leader, this
means that the update of the protocol parameters is now a responsability
of the leader only.

This lead to flakiness because this step was restarting all aggregators,
and sometimes the follower started before the leader and had a error
when it executed its handle discrepencies because the leader http server
was still down.
@Alenar @turmelclem
feat(e2e): output logs in expandable group when running in github act…
cf71a90 
…ions
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch from 6752f97 to ea59e83 Compare November 7, 2025 14:09
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1-local-parameters branch from ea59e83 to de20459 Compare November 7, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@turmelclem turmelclem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turmelclem @Alenar