Skip to content

Conversation

frx08
Copy link
Contributor

@frx08 frx08 commented Sep 23, 2025

Description of proposed changes

Fix ValueError: zero-size array to reduction operation minimum in
auto_adjust_colormap_lut_and_disp_limit.

  • Handle the case where input data has no finite values.
  • Return neutral display limits [0.0, 0.0] and None LUT when no valid pixels are found.
  • Prevents crashes in view.py plotting when datasets are fully NaN/invalid.

Reminders

  • Fix #xxxx
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Summary by Sourcery

Handle empty or fully invalid data in auto_adjust_colormap_lut_and_disp_limit by returning default neutral display limits and None LUT instead of crashing

Bug Fixes:

  • Avoid ValueError from zero-size array reduction when no finite values are present

Enhancements:

  • Warn when no valid pixels are found and return display limits [0.0, 0.0] with a None LUT

Avoid ValueError when input has no finite values by returning neutral
display limits [0.0, 0.0] and None LUT. This prevents crashes in view.py
plotting when datasets are fully NaN or invalid.
Copy link
Contributor

sourcery-ai bot commented Sep 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates auto_adjust_colormap_lut_and_disp_limit to gracefully handle cases where the input data contains no finite values by early exiting with default display limits and prevents crashes by refactoring the way unique values are extracted.

File-Level Changes

Change Details Files
Introduce empty-data handling with default return
  • Mask invalid entries and create finite_values array
  • Check for zero-size finite_values
  • Print warning and return neutral limits [0.0, 0.0] with None LUT
src/mintpy/utils/plot.py
Refactor unique value computation to use masked finite data
  • Replace direct NaN filtering with np.unique on finite_values
src/mintpy/utils/plot.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant