-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses same code for source code generation in modules #1301
Uses same code for source code generation in modules #1301
Conversation
…te_output@main * 1187_decorate_output@main: fix: tm_t_coxreg bug
Hey @averissimo I see this one in the first module |
I've updated the apps and corrected one more bug in the feature branch (already merged here)
No action: They are only present on the reporter.
Fixed the app: by moving to second application. The
Fixed: Bug in decorators, fixed in feature branch and merged here
No action: Moved to second application |
Thanks @averissimo - will re-review |
Vitals: Show R Code Warning: Error in : object 'source_code_r' not found
1: shiny::runApp |
Second app - MMRM When going between outputs you can see that UI presents an error because data hasn't changed yet. Any way to delay that? mmrm.mp4 |
Other than that, everything works like a charm : )! great job! |
Thanks @m7pr Starting with the unfixable:
What was fixed:
Sorry about this, it was too many modules, fixed now. Ready for another round! |
Amazing @averissimo - thanks for the work! Do we have a card for handling those two? I would start those, at least just to bring the attention to discuss those mmrm: We need to decouple decorators from transformators or extend it to ignore temporary error states.
Regardless, this is out of the scope of tmc and is a teal issue
Adverse events: known bug that is the same as mmrm |
@m7pr we do: insightsengineering/teal#1421 It's a question but I'll extend with a practical example |
Part of insightsengineering/teal#1371
Example app with all modules / decorators
Example app
Second App