Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-release vignettes review #681

Merged
merged 14 commits into from
Feb 28, 2024

Conversation

kartikeyakirar
Copy link
Contributor

PR to #640

@kartikeyakirar kartikeyakirar marked this pull request as draft February 26, 2024 10:01
@kartikeyakirar kartikeyakirar marked this pull request as ready for review February 27, 2024 13:57
@vedhav
Copy link
Contributor

vedhav commented Feb 27, 2024

I was testing if all the apps fro the vignettes worked after the modules as a variable change.
All the example apps worked except for the example in the vignette using-scatterplot-matrix.Rmd
Error:

Listening on http://127.0.0.1:7784
Browsing http://127.0.0.1:7784
[INFO] 2024-02-27 20:09:27.6905 pid:97964 token:[6b67bbd1] teal Initializing reporter_previewer_module
Warning: Error in teal.transform::data_extract_ui: more than one dataset in data_extract_spec but is_single_dataset parameter is set to TRUE
  3: runApp
  2: print.shiny.appobj
  1: <Anonymous>

@kartikeyakirar
Copy link
Contributor Author

kartikeyakirar commented Feb 27, 2024

I was testing if all the apps fro the vignettes worked after the modules as a variable change.
All the example apps worked except for the example in the vignette using-scatterplot-matrix.Rmd

@vedhav, I reviewed the tm_g_scatterplotmatrix function and noticed that it uses teal.transform::is_single_dataset on the variables parameter. In the case of the "Multiple wide datasets" module configuration, we currently utilize ADSL twice, whereas previously we used ADSL2. The teal.transform::is_single_dataset function checks the data names in the variables parameter and identifies only a single name, "ADSL," which leads to this problem. I removed f248a85 this mod2 to resolve the issue. as we had only single wide dataset now. (let me know if you have alternative suggestions)

@vedhav vedhav self-requested a review February 28, 2024 05:23
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kartikeyakirar LGTM now.

@kartikeyakirar kartikeyakirar merged commit 804d79a into pre-release@main Feb 28, 2024
@kartikeyakirar kartikeyakirar deleted the vignettes_review@pre-release@main branch February 28, 2024 07:33
averissimo added a commit that referenced this pull request Feb 28, 2024
…tions_process@pre-release@main

* origin/pre-release@main:
  removed @nord tags and added return from shared_params
  missing comma
  641 non exported functions (#680)
  pre-release vignettes review (#681)
  [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
  Standardise function titles similar to what we have in tmc (#691)
  [skip actions] Bump version to 0.2.16.9026
  `tm_g_regression` labels are no longer allowed out of bounds (#675)
  [skip actions] Bump version to 0.2.16.9025
  Remove the internal function `var_labels` in favour of `teal.data::col_labels` (#690)
  [skip actions] Bump version to 0.2.16.9024
  Fix the silent error in `tm_a_pca` (#688)
@m7pr
Copy link
Contributor

m7pr commented Feb 28, 2024

@kartikeyakirar does this close #640 ?

@kartikeyakirar
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants