-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-release vignettes review #681
pre-release vignettes review #681
Conversation
Closes #640 --------- Signed-off-by: Vedha Viyash <[email protected]>
I was testing if all the apps fro the vignettes worked after the modules as a variable change. Listening on http://127.0.0.1:7784
Browsing http://127.0.0.1:7784
[INFO] 2024-02-27 20:09:27.6905 pid:97964 token:[6b67bbd1] teal Initializing reporter_previewer_module
Warning: Error in teal.transform::data_extract_ui: more than one dataset in data_extract_spec but is_single_dataset parameter is set to TRUE
3: runApp
2: print.shiny.appobj
1: <Anonymous> |
@vedhav, I reviewed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kartikeyakirar LGTM now.
…tions_process@pre-release@main * origin/pre-release@main: removed @nord tags and added return from shared_params missing comma 641 non exported functions (#680) pre-release vignettes review (#681) [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update Standardise function titles similar to what we have in tmc (#691) [skip actions] Bump version to 0.2.16.9026 `tm_g_regression` labels are no longer allowed out of bounds (#675) [skip actions] Bump version to 0.2.16.9025 Remove the internal function `var_labels` in favour of `teal.data::col_labels` (#690) [skip actions] Bump version to 0.2.16.9024 Fix the silent error in `tm_a_pca` (#688)
@kartikeyakirar does this close #640 ? |
yes |
PR to #640