Fix CSS load when we use only fixed picks UI container#76
Merged
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: 2aeab9d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 10 suites 16s ⏱️ Results for commit 2aeab9d. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 829ce00 ♻️ This comment has been updated with latest results. |
averissimo
requested changes
May 7, 2026
Contributor
averissimo
left a comment
There was a problem hiding this comment.
I don't like the move of the CSS tag, please see comment below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixing this issue #75
Please compare the screenshot in the issue with this branch. You can try this example:
The fix consisted on loading the css differently. Previously, the CSS was being loaded only when we used the clickable badge dropdown. Now, if the developer does not provide a custom container, we load the css regardless of using fixed or clickable picks UI.
See that the styling is correct now