-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predator-Prey Flock Environment #247
Comments
Thanks for opening the issue, I remember chatting to you about this env on reddit 👋 Personally I think it would be a nice addition, although this is supposed to be an industry focused benchmark suite, so I'll wait for @clement-bonnet to give his opinion. If you are happy to implement this I'm happy to review it, but I can't devote too much other time to this |
Hi @zombie-einstein sorry for leaving this hanging for a while if you are still interested in adding this to jumanji we'd be happy to accept the addition 🙏 |
No worries @sash-a , great I'll look to make a start on this! |
Closing this issue. Will open a PR with implementation. |
Hi @sash-a just wanted to check what the best tactic was to get this reviewed. I've got the core functionality on a branch of my fork here, but it's still missing docs, some more in-depth tests, etc.
|
Good question, so we usually use option 3 and just review the whole PR at once. Option two sounds best but honestly I'm quite used to option 3, so just go ahead and create a big PR for the whole thing, it ends up taking a while and getting lots of comments but I think it's relatively well tried and tested |
Re-opening until this env is merged 😄 |
Thanks, yeah makes sense. |
Hi, I am the maintainer/creator of Esquilax a JAX large scale sim and RL environment library.
As a first use case of the library I've been working on a predator-prey training environment:
Would this be something you'd be interested in porting into Jumanji? I'd be happy to work on implementation. The version on the linked repo is an initial prototype, with lots of scope to add different setups (e.g. communication between predators, multiple competing agent types).
The text was updated successfully, but these errors were encountered: