Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predator-Prey Flock Environment #247

Open
zombie-einstein opened this issue Oct 11, 2024 · 8 comments
Open

Predator-Prey Flock Environment #247

zombie-einstein opened this issue Oct 11, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@zombie-einstein
Copy link

Hi, I am the maintainer/creator of Esquilax a JAX large scale sim and RL environment library.

As a first use case of the library I've been working on a predator-prey training environment:

  • Two sets of agents aim to pursue/evade each other
  • It's intended for larger scale use cases (i.e. 100s of agents)
  • Each agent has a simple view model of the surrounding environment, allowing for observations space to independent of the number of agents
  • All implemented in native JAX

Would this be something you'd be interested in porting into Jumanji? I'd be happy to work on implementation. The version on the linked repo is an initial prototype, with lots of scope to add different setups (e.g. communication between predators, multiple competing agent types).

@zombie-einstein zombie-einstein added the enhancement New feature or request label Oct 11, 2024
@sash-a
Copy link
Collaborator

sash-a commented Oct 11, 2024

Hi @zombie-einstein

Thanks for opening the issue, I remember chatting to you about this env on reddit 👋

Personally I think it would be a nice addition, although this is supposed to be an industry focused benchmark suite, so I'll wait for @clement-bonnet to give his opinion.

If you are happy to implement this I'm happy to review it, but I can't devote too much other time to this

@sash-a
Copy link
Collaborator

sash-a commented Oct 24, 2024

Hi @zombie-einstein sorry for leaving this hanging for a while if you are still interested in adding this to jumanji we'd be happy to accept the addition 🙏

@zombie-einstein
Copy link
Author

No worries @sash-a , great I'll look to make a start on this!

@zombie-einstein
Copy link
Author

Closing this issue. Will open a PR with implementation.

@zombie-einstein
Copy link
Author

Hi @sash-a just wanted to check what the best tactic was to get this reviewed. I've got the core functionality on a branch of my fork here, but it's still missing docs, some more in-depth tests, etc.
I was trying to avoid opening too large a PR, so what was best to do?

  • Open a PR for the added functionality and then additional PRs to finalise?
  • Use the Fork as a staging area and review PRs into the Fork main, before merging the whole fork?
  • Just finish up the whole thing in one big PR?

@sash-a
Copy link
Collaborator

sash-a commented Nov 2, 2024

Good question, so we usually use option 3 and just review the whole PR at once. Option two sounds best but honestly I'm quite used to option 3, so just go ahead and create a big PR for the whole thing, it ends up taking a while and getting lots of comments but I think it's relatively well tried and tested

@sash-a
Copy link
Collaborator

sash-a commented Nov 2, 2024

Re-opening until this env is merged 😄

@sash-a sash-a reopened this Nov 2, 2024
@zombie-einstein
Copy link
Author

Thanks, yeah makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants