Add service entries#201
Closed
Milica-Cvrkota-IBM wants to merge 2 commits intomainfrom
Closed
Conversation
5a9fdcc to
230ddc7
Compare
konrad-ohms
requested changes
Aug 5, 2024
| return false | ||
| } | ||
|
|
||
| return strings.Contains(meshConfig, "REGISTRY_ONLY") |
Contributor
There was a problem hiding this comment.
How would the configmap content look like, is a string.Contains a safe check here?
Contributor
There was a problem hiding this comment.
Got the message via Slack (thanks).
$ k get cm istio -o yaml
apiVersion: v1
data:
mesh: |-
accessLogFile: /dev/stdout
defaultConfig:
discoveryAddress: istiod.istio-system.svc:15012
proxyMetadata: {}
tracing:
zipkin:
address: zipkin.istio-system:9411
defaultProviders:
metrics:
- prometheus
enablePrometheusMerge: true
extensionProviders:
- envoyOtelAls:
port: 4317
service: opentelemetry-collector.istio-system.svc.cluster.local
name: otel
- name: skywalking
skywalking:
port: 11800
service: tracing.istio-system.svc.cluster.local
- name: otel-tracing
opentelemetry:
port: 4317
service: opentelemetry-collector.otel-collector.svc.cluster.local
outboundTrafficPolicy:
mode: REGISTRY_ONLY
rootNamespace: istio-system
trustDomain: cluster.local
meshNetworks: 'networks: {}'
kind: ConfigMap
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"v1","data":{"mesh":"accessLogFile: /dev/stdout\ndefaultConfig:\n discoveryAddress: istiod.istio-system.svc:15012\n proxyMetadata: {}\n tracing:\n zipkin:\n address: zipkin.istio-system:9411\ndefaultProviders:\n metrics:\n - prometheus\nenablePrometheusMerge: true\nextensionProviders:\n- envoyOtelAls:\n port: 4317\n service: opentelemetry-collector.istio-system.svc.cluster.local\n name: otel\n- name: skywalking\n skywalking:\n port: 11800\n service: tracing.istio-system.svc.cluster.local\n- name: otel-tracing\n opentelemetry:\n port: 4317\n service: opentelemetry-collector.otel-collector.svc.cluster.local\noutboundTrafficPolicy:\n mode: REGISTRY_ONLY\nrootNamespace: istio-system\ntrustDomain: cluster.local","meshNetworks":"networks: {}"},"kind":"ConfigMap","metadata":{"annotations":{},"labels":{"install.operator.istio.io/owning-resource":"unknown","install.operator.istio.io/owning-resource-namespace":"istio-system","istio.io/rev":"default","operator.istio.io/component":"Pilot","operator.istio.io/managed":"Reconcile","operator.istio.io/version":"1.18.0","release":"istio"},"name":"istio","namespace":"istio-system"}}
creationTimestamp: "2024-08-05T12:31:26Z"
labels:
install.operator.istio.io/owning-resource: unknown
install.operator.istio.io/owning-resource-namespace: istio-system
istio.io/rev: default
operator.istio.io/component: Pilot
operator.istio.io/managed: Reconcile
operator.istio.io/version: 1.18.0
release: istio
name: istio
namespace: istio-system
resourceVersion: "436321423"
uid: 432e0200-90d6-443c-b87e-2cbd8de5f467
Contributor
There was a problem hiding this comment.
I would propose to exactly check outboundTrafficPolicy: mode: REGISTRY_ONLY in that case.
Is that string always uppercase?
0edba70 to
3464ea6
Compare
Contributor
|
@Milica-Cvrkota-IBM is this branch still necessary? Thanks. |
1ee9448 to
2709a59
Compare
a586c60 to
6f12e88
Compare
Signed-off-by: Milica Cvrkota <milica.cvrkota@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.