Skip to content

Add service entries#201

Closed
Milica-Cvrkota-IBM wants to merge 2 commits intomainfrom
add-service-entries
Closed

Add service entries#201
Milica-Cvrkota-IBM wants to merge 2 commits intomainfrom
add-service-entries

Conversation

@Milica-Cvrkota-IBM
Copy link
Copy Markdown
Contributor

No description provided.

@Milica-Cvrkota-IBM Milica-Cvrkota-IBM requested a review from a team as a code owner July 22, 2024 13:18
@Milica-Cvrkota-IBM Milica-Cvrkota-IBM force-pushed the add-service-entries branch 4 times, most recently from 5a9fdcc to 230ddc7 Compare July 30, 2024 13:53
Comment thread controllers/util.go Outdated
return false
}

return strings.Contains(meshConfig, "REGISTRY_ONLY")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would the configmap content look like, is a string.Contains a safe check here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the message via Slack (thanks).

$ k get cm istio -o yaml
apiVersion: v1
data:
  mesh: |-
    accessLogFile: /dev/stdout
    defaultConfig:
      discoveryAddress: istiod.istio-system.svc:15012
      proxyMetadata: {}
      tracing:
        zipkin:
          address: zipkin.istio-system:9411
    defaultProviders:
      metrics:
      - prometheus
    enablePrometheusMerge: true
    extensionProviders:
    - envoyOtelAls:
        port: 4317
        service: opentelemetry-collector.istio-system.svc.cluster.local
      name: otel
    - name: skywalking
      skywalking:
        port: 11800
        service: tracing.istio-system.svc.cluster.local
    - name: otel-tracing
      opentelemetry:
        port: 4317
        service: opentelemetry-collector.otel-collector.svc.cluster.local
    outboundTrafficPolicy:
      mode: REGISTRY_ONLY
    rootNamespace: istio-system
    trustDomain: cluster.local
  meshNetworks: 'networks: {}'
kind: ConfigMap
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","data":{"mesh":"accessLogFile: /dev/stdout\ndefaultConfig:\n  discoveryAddress: istiod.istio-system.svc:15012\n  proxyMetadata: {}\n  tracing:\n    zipkin:\n      address: zipkin.istio-system:9411\ndefaultProviders:\n  metrics:\n  - prometheus\nenablePrometheusMerge: true\nextensionProviders:\n- envoyOtelAls:\n    port: 4317\n    service: opentelemetry-collector.istio-system.svc.cluster.local\n  name: otel\n- name: skywalking\n  skywalking:\n    port: 11800\n    service: tracing.istio-system.svc.cluster.local\n- name: otel-tracing\n  opentelemetry:\n    port: 4317\n    service: opentelemetry-collector.otel-collector.svc.cluster.local\noutboundTrafficPolicy:\n  mode: REGISTRY_ONLY\nrootNamespace: istio-system\ntrustDomain: cluster.local","meshNetworks":"networks: {}"},"kind":"ConfigMap","metadata":{"annotations":{},"labels":{"install.operator.istio.io/owning-resource":"unknown","install.operator.istio.io/owning-resource-namespace":"istio-system","istio.io/rev":"default","operator.istio.io/component":"Pilot","operator.istio.io/managed":"Reconcile","operator.istio.io/version":"1.18.0","release":"istio"},"name":"istio","namespace":"istio-system"}}
  creationTimestamp: "2024-08-05T12:31:26Z"
  labels:
    install.operator.istio.io/owning-resource: unknown
    install.operator.istio.io/owning-resource-namespace: istio-system
    istio.io/rev: default
    operator.istio.io/component: Pilot
    operator.istio.io/managed: Reconcile
    operator.istio.io/version: 1.18.0
    release: istio
  name: istio
  namespace: istio-system
  resourceVersion: "436321423"
  uid: 432e0200-90d6-443c-b87e-2cbd8de5f467

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to exactly check outboundTrafficPolicy: mode: REGISTRY_ONLY in that case.
Is that string always uppercase?

@Milica-Cvrkota-IBM Milica-Cvrkota-IBM force-pushed the add-service-entries branch 2 times, most recently from 0edba70 to 3464ea6 Compare August 8, 2024 15:58
@konrad-ohms
Copy link
Copy Markdown
Contributor

@Milica-Cvrkota-IBM is this branch still necessary?
If yes, please rebase it from main, as we changed the resource locking mechanism and your pipeline would not start to build otherwise.

Thanks.

@Milica-Cvrkota-IBM Milica-Cvrkota-IBM force-pushed the add-service-entries branch 3 times, most recently from 1ee9448 to 2709a59 Compare January 20, 2025 14:19
@Milica-Cvrkota-IBM Milica-Cvrkota-IBM force-pushed the add-service-entries branch 3 times, most recently from a586c60 to 6f12e88 Compare April 7, 2025 13:51
Signed-off-by: Milica Cvrkota <milica.cvrkota@ibm.com>
@cvrkota cvrkota closed this Aug 5, 2025
@cvrkota cvrkota deleted the add-service-entries branch August 5, 2025 07:11
@cvrkota cvrkota restored the add-service-entries branch August 5, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants