Use display refresh rate for animations #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6314d3a.
This reverts commit 8dea2c5.
For some reason, I assumed the goal of this line was to halve the framerate but preserve the time spent in the animation... Since I'm pretty sure that wasn't the intent, undo the change
I am an intelligent person who does things intelligently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows instantWM to render animations at the display's native refresh rate, instead of being locked to 60Hz.
At the moment this results in slightly bizarre code, as all the calls to
animateclient()still assume 60Hz when specifying how many frames to render. This isn't necessarily a problem, it just means that when specifying how many frames to render, it's actually specifying how many frames to render assuming we're running at 60Hz, and otherwise it will be scaled to match the display.Ideally this would be changed to something more universal, like a number of milliseconds to animate for, but it works just fine currently.
PS: don't mind the weird commit log, I forgot to make a branch for my changes when I made this fork so I've had to clean it up in order to PR lol