Skip to content

Conversation

@courtneypacheco
Copy link
Contributor

This PR updates the constraints-dev.txt file using tox -e constraints.

@mergify mergify bot added the ci-failure label Jun 9, 2025
@booxter
Copy link
Contributor

booxter commented Jun 9, 2025

looks like this fix should be applied here too: instructlab/eval@b8fedae

@bbrowning
Copy link
Contributor

Hmm - how am I still getting torch and nvidia libraries in here? Will need to debug that...

@booxter
Copy link
Contributor

booxter commented Jun 9, 2025

As per the comment,

torch==2.7.1              # via docling-ibm-models, easyocr, safetensors, torchvision

These are dependencies that pull it.

@bbrowning
Copy link
Contributor

Right - it's just odd that these weren't in there before. But, I think the issue is originally I generated this file on a mac but now CI is generating it from a linux machine and that leads to substantially different set of packages included 😓

@booxter
Copy link
Contributor

booxter commented Jun 9, 2025

@booxter
Copy link
Contributor

booxter commented Jun 9, 2025

@Mergifyio rebase

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2025

rebase

✅ Branch has been successfully rebased

@booxter booxter force-pushed the update-constraints branch from e393fdf to 70d9fbc Compare June 9, 2025 19:38
@booxter
Copy link
Contributor

booxter commented Jun 9, 2025

@ktdreyer why is it complaining about DCO here? Haven't we disabled it? Or is it some setting on the org level that should be adjusted?

Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks passed. DCO should be disabled so I think we could merge the PR.

@mergify mergify bot added the one-approval label Jun 9, 2025
@ktdreyer
Copy link
Contributor

ktdreyer commented Jun 9, 2025

@ktdreyer why is it complaining about DCO here? Haven't we disabled it? Or is it some setting on the org level that should be adjusted?

That's right, I needed to adjust it in the org. I've done that and put a comment in the main ticket instructlab/dev-docs#192 for the record.

@bbrowning bbrowning merged commit 0f24ad8 into main Jun 9, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants