fix double-sync #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maths22
approved these changes
Oct 5, 2023
if the preamble already exists, injecting the preamble would evaluate the gemfile, and recursively load the plugin (and plugins.rb). avoid the problems of that by only adding at_exit hooks in multilock.rb, which will only be required once. the plugin hook needs to be more carefully considered, because they'll be reset multiple times - so avoid the re-entrant load in the first place
ccutrer
force-pushed
the
fix-double-sync
branch
from
1bb0f26 to
8a6df24
Compare
maths22
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the preamble already exists, injecting the preamble would evaluate the gemfile, and recursively load the plugin (and plugins.rb). avoid the problems of that by only adding our hooks in multilock.rb, which will only be required once