Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syncing a gem update that changes platforms #43

Merged
merged 2 commits into from
May 18, 2024

Conversation

ccutrer
Copy link
Collaborator

@ccutrer ccutrer commented May 17, 2024

No description provided.

@ccutrer ccutrer force-pushed the fix-platform-changing-update branch 4 times, most recently from 6a50e19 to 2028c61 Compare May 17, 2024 22:10
ccutrer added 2 commits May 18, 2024 08:56
the key to this hash is [spec_name, platform], not simply name, so this
loop was never doing anything. it will likely come back soon, in a fixed
form, but is breaking my next commit that I don't want to fix this loop
yet
@ccutrer ccutrer force-pushed the fix-platform-changing-update branch from 2028c61 to 55f8dcd Compare May 18, 2024 14:56
@ccutrer ccutrer changed the title fix syncing a gem update that changes platformsFix platform changing update fix syncing a gem update that changes platforms May 18, 2024
@ccutrer ccutrer marked this pull request as ready for review May 18, 2024 14:57
@ccutrer ccutrer requested review from rmsy, maths22 and aogata-inst May 18, 2024 19:27
@ccutrer ccutrer merged commit 5ba3464 into instructure:main May 18, 2024
17 checks passed
@ccutrer ccutrer deleted the fix-platform-changing-update branch May 18, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants