Skip to content

[Horizon] Tab bar icons #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

[Horizon] Tab bar icons #3037

merged 1 commit into from
Jan 6, 2025

Conversation

Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93
feat: Update tab bat icons
74be4de 
[ignore-commit-lint]
@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Dec 18, 2024
@inst-danger
Copy link
Contributor

Horizon Build QR Code:

@inst-danger
Copy link
Contributor

Fails
🚫 Build failed, skipping coverage check
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor 
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")

Generated by 🚫 dangerJS against 74be4de

@Ahmed-Naguib93 Ahmed-Naguib93 merged commit c7f7fb2 into feature/horizon Jan 6, 2025
2 of 4 checks passed
@Ahmed-Naguib93 Ahmed-Naguib93 deleted the feature/horizon-CLX-283-Update-tab-bar-icons branch January 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reabbotted reabbotted reabbotted approved these changes

@szabinst szabinst szabinst approved these changes

@ktheory ktheory Awaiting requested review from ktheory ktheory is a code owner

@JacksonHowe JacksonHowe Awaiting requested review from JacksonHowe JacksonHowe is a code owner

Assignees

@Ahmed-Naguib93 Ahmed-Naguib93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ahmed-Naguib93 @inst-danger @reabbotted @szabinst