Reorganize Core files

[rh12]

affects: Student, Teacher, Parent
release note: none

Reorganized the files in Core project. See screenshot below.

• Everything is under Common and Features now.
• Fixed some filename errors, in rare cases updated the classname itself.
• Split some files, mostly extensions.
• Didn't refactor anything, didn't touch any logic.
• Synced CoreTests structure with Core structure.
• Cleaned up coverage/config.json

Some notes:

• Didn't try to straighten out Logger vs Analytics vs ScreenViewLogger vs PageViewAnalytics. But they are all in CommonModels and CommonUI now.
• Didn't try to straighten out SwiftUIViews, ViewModifiers, UIViews, ViewModel, Viewables, etc. Plus there is InstUI. But they are all in CommonUI now.
• CommonUI has both UIKit and SwiftUI related types. It was not trivial to separate the two, so I left them together.
• Didn't try to reorganize or straighten out the features themselves.

Test plan

Build and run all three apps.
I suggest to checkout and see locally because on github it's slow.

Screenshots

[inst-danger]

Teacher Build QR Code:

[inst-danger]

Parent Build QR Code:

[inst-danger]

Student Build QR Code:

[inst-danger]

	Fails
🚫	Please add a reference to a Jira ticket. For example: refs: MBL-10023

	Warnings
⚠️	This pull request will not generate a release note.
⚠️	One or more files are below the minimum test coverage 50%

Affected Apps: Student, Teacher, Parent

Coverage	New %	Master %	Delta
Canvas iOS	91.28%	91.24%	0.04%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift	48.72%	--	--
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift	0%	--	--
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift	30.77%	--	--
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift	0%	--	--
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift	0%	--	--
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift	32.76%	--	--

Generated by 🚫 dangerJS against 76e9de6

[suhaibabsi-inst]

Checking out this branch on my machine, I had the following issue:
1- An empty "Planner/CalendarEvent" folder found beneath "Features" & "Common"
2- Two "Assets" files was found, at "Core" and "Core/Resources". I am wondering whether we need such arrangement?

[rh12]

Hi @suhaibabsi-inst

Checking out this branch on my machine, I had the following issue:
1- An empty "Planner/CalendarEvent" folder found beneath "Features" & "Common"

This is probably caused by an empty folder in your local repository. Git ignores empty folders but the project generation script doesn't. Please just remove the folder itself. It should not be there on a fresh checkout/clone.

2- Two "Assets" files was found, at "Core" and "Core/Resources". I am wondering whether we need such arrangement?
I believe it's the same. There is probably a leftover empty Assets.xcassets folder.

I don't have any of these and since we can't affect empty folders in a commit I believe a local cleanup may be needed (or a clean checkout) if you have some leftovers.

[vargaat]

I welcome these changes, thanks for taking the time to do them! Feedback:

1. I think we could omit the Common prefix on subfolders. I would also stick to the MVVM layer naming and rename Models to Model and the UI folder to View as we have with other modules.
   

2. We could also omit the Extensions suffix from these directories. I don't feel the added value but it's harder to read.
   

[rh12]

1. I think we could omit the Common prefix on subfolders. I would also stick to the MVVM layer naming and rename Models to Model and the UI folder to View as we have with other modules.

The Common prefix felt a bit more expressive to me in this case, but I'm not entirely against removing it.
I thought about Model/View originally, but it doesn't really follow MVVM in this level. Event though Models contain only Model level code, the UI contains all layers within each component. So I would intentionally keep it UI (or CommonUI).
Separation of components and organization was not clearcut here, thing could be improved more later on I think.

2. We could also omit the Extensions suffix from these directories. I don't feel the added value but it's harder to read.

I agree, will change them! (note to self: Webkit -> WebKit)

[szabinst]

Since we have Resources folder, I'd introduce Sources folder for everything else.

I'd also drop the prefixes but I'm hesitant on the MVVM splitting here because they are not really implemented that way.

In Horizon, I did split the common folder but it was easier because everything was written from scratch with separation of concerns in mind.

[rh12]

As discussed on Slack with @vargaat and @szabinst we will leave Common folder naming as it is and consider further organization/cleanup for its contents later on.

[ndrsszsz]

Nice! 👍