Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen #3042

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Dec 22, 2024

refs: MBL-18084
affects: Student
release note: Fixed grade preferences screen not displaying grading periods in some cases.

What's changed

The resolution was basically to hide the filter button on screen appearance, until the loading finishes for the first time. Subsequent reloading won't hide it again.

Screen Recording

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-22.at.17.09.18.mp4

Test Plan

  • Login to a student account
  • Navigate to a course Grades screen
  • While initial loading, filter button is not being displayed
  • After first loading, on success or failure, filter button must be displayed.
  • Try reloading the screen or picking a grading period from filter screen, at all cases filter button should still be displayed.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

…Grades Filter screen

refs: MBL-18084
affects: Student
release note: Fixes E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen
@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 22, 2024

Fails
🚫 Build failed, skipping coverage check

Release Note:

Fixes E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen

Affected Apps: Student

MBL-18084

❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")

Generated by 🚫 dangerJS against 7b11fab

@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review December 22, 2024 14:16
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1, it works in the app as described

@rh12 rh12 merged commit 401ebe2 into master Jan 7, 2025
2 of 4 checks passed
@rh12 rh12 deleted the bugfix/MBL-18084-GradingPeriods-E2E-Issue branch January 7, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants