Updated sentence #1960
Open
Updated sentence #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page...')
To:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page.')
It does not make sense to have '...' and doesn't look like it quite fits in. Having a simple '.' looks better, as well as doesn't imply anything like '...' does.
Test Plan:
- When taking a quiz intentionally blur the page and finish the quiz.
- Look at the quiz log and ensure it only states "Stopped viewing the Canvas quiz-taking page."
rhian-cs
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page...')
To:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page.')
It does not make sense to have '...' and doesn't look like it quite fits in. Having a simple '.' looks better, as well as doesn't imply anything like '...' does.
Test Plan: