Fix observer enrollment impacting section privileges of teacher #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating observer enrollments, copy the limit_course_section_privilege value over from the student enrollment closes instructuregh-2245 Test Plan: - Enroll a teacher in a section of course with limit section privileges set to true - Enroll a student in a different section of the same course with limit section privileges set to true - Set up the teacher as an observer of the student (for example the teacher teaches a section of a course but has a son or daughter taking a different section of the same course) Confirm the teacher cannot view all sections and can only see the two sections.
cgravatt
force-pushed
the
2245-fix-observer-enrollment-impacting-limit-section-privileges
branch
from
b10e898 to
593e1a1
Compare
cgravatt
commented
Aug 16, 2023
| student = user_with_pseudonym | ||
| @course.enroll_student(student, enrollment_state: "active", section: @section1, limit_privileges_to_course_section: true) | ||
| add_linked_observer(student, limited_teacher) | ||
| expect(@course.course_section_visibility(limited_teacher)).to eq [@section1.id, @section2.id] |
There was a problem hiding this comment.
test fails and returns :all before change
|
Any feedback on this? |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visibility_limited_to_course_sections? should return true if all of the enrollments have limited_section_privileges ignoring observer enrollments
closes gh-2245
Test Plan: