Add .exe extension to Windows distribution (#534)

int128 · Apr 17, 2021 · 4ca11f1 · 4ca11f1
1 parent 0b6d34e
commit 4ca11f1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/go.yaml b/.github/workflows/go.yaml
@@ -8,6 +8,7 @@ on:
       - .github/workflows/go.yaml
       - pkg/**
       - go.*
+      - Makefile
     tags:
       - v*
   pull_request:
@@ -17,6 +18,7 @@ on:
       - .github/workflows/go.yaml
       - pkg/**
       - go.*
+      - Makefile
 
 jobs:
   lint:

diff --git a/.krew.yaml b/.krew.yaml
@@ -54,7 +54,7 @@ spec:
       matchLabels:
         os: darwin
         arch: arm64
-  - bin: kubelogin
+  - bin: kubelogin.exe
     {{ addURIAndSha "https://github.com/int128/kubelogin/releases/download/{{ .TagName }}/kubelogin_windows_amd64.zip" .TagName }}
     selector:
       matchLabels:

diff --git a/Makefile b/Makefile
@@ -1,6 +1,12 @@
-TARGET := kubelogin
-TARGET_ARCHIVE := $(TARGET)_$(GOOS)_$(GOARCH).zip
-TARGET_DIGEST := $(TARGET)_$(GOOS)_$(GOARCH).zip.sha256
+PRODUCT := kubelogin
+TARGET_ARCHIVE := $(PRODUCT)_$(GOOS)_$(GOARCH).zip
+TARGET_DIGEST := $(PRODUCT)_$(GOOS)_$(GOARCH).zip.sha256
+
+ifeq ($(GOOS), windows)
+  TARGET := $(PRODUCT).exe
+else
+  TARGET := $(PRODUCT)
+endif
 
 # determine the version from ref
 ifeq ($(GITHUB_REF), refs/heads/master)