Fix scheme parameter in test_mxfp4 to match expected precision #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: xin3he <[email protected]>
Copilot
AI
changed the title
[WIP] Fix CUDA UT fail based on review feedback
Fix scheme parameter in test_mxfp4 to match expected precision
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from #1237 to correct the scheme parameter in
test_mxfp4.Changes
scheme="MXFP8_RCEIL"toscheme="MXFP4_RCEIL"intest/test_cuda/test_scheme.py:45The test validates 4-bit precision (
assert ar.bits == 4) but was incorrectly using the 8-bit scheme. This aligns the scheme parameter with the test name and expected behavior.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.