qgs: add -m=MODE parameter for UNIX socket mode#451
Open
berrange wants to merge 1 commit intointel:mainfrom
Open
qgs: add -m=MODE parameter for UNIX socket mode#451berrange wants to merge 1 commit intointel:mainfrom
berrange wants to merge 1 commit intointel:mainfrom
Conversation
The UNIX socket mode default is controlled by the process umask, but it can be desirable to override this to open up the socket mode, while keeping the umask restrictive. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
berrange
force-pushed
the
qgs-sock-mode
branch
from
375bf22 to
cea7fa0
Compare
Contributor
Author
|
Rebased to latest git main. NB, this will conflict with my other PR #428 that adds --debug/--verbose parameters, since both patches modify the help output. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UNIX socket mode default is controlled by the process umask, but it can be desirable to override this to open up the socket mode, while keeping the umask restrictive.
For example, to allow QEMU to connect to the socket, it needs to be world accessible, while the default umask of 0700 set by systemd will normally limit its access to only the qgs user.