[InstCombine]PtrReplacer: Correctly handle select with unavailable op… #19908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erands (#148829) The testcase I added previously failed because a SelectInst with invalid operands was created (one side `addrspace(4)`, the other `addrspace(5)`). PointerReplacer needs to dig deeper if the true and/or false instructions of the select are not available. Fixes SWDEV-542957 (cherry picked from commit f223411)
|
This is a cherry-pick of a commit on upstream LLVM. It would be nice to have this applied before the next pulldown, because the problem makes us unable to build SYCL-CTS for Native CPU. |
|
Who the best code reviewer could be? I think that Tools team doesn't have too much expertise in InstCombine. |
AlexeySachkov
approved these changes
Sep 2, 2025
sarnex
approved these changes
Sep 2, 2025
|
@hvdijk is this ready for merge? |
It is, and it is, yes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erands (#148829)
The testcase I added previously failed because a SelectInst with invalid operands was created (one side
addrspace(4), the otheraddrspace(5)).PointerReplacer needs to dig deeper if the true and/or false instructions of the select are not available.
Fixes SWDEV-542957
(cherry picked from commit f223411)