[UR] Fix usm pools creation failure at context initialization #19921
+56
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
force-pushed
the
subsub_context
branch
from
f5ae2d1 to
d4396d1
Compare
againull
force-pushed
the
subsub_context
branch
2 times, most recently
from
551a6a4 to
cdbe9f6
Compare
againull
changed the title
Context creation was failing when sub-sub-devices were exposed, because the Level Zero adapter attempted to add multiple USM pools with identical descriptors. This occurred since, for the L0 backend, sub-sub-devices and their parent sub-devices share the same Level Zero device handle and should use the same USM pool. This PR resolves the issue by ensuring only devices with unique Level Zero handles are collected for USM pool creation, preventing duplicate pools. Additionally, this PR fixes an issue with an uninitialized `ur_device_partition_property_t` variable passed to UR. Previously, this could result in an unexpected value for `value.affinity_domain` when the property type was `UR_DEVICE_PARTITION_BY_CSLICE` resulting on error from adapter.
againull
force-pushed
the
subsub_context
branch
from
cdbe9f6 to
3cca892
Compare
pbalcer
approved these changes
Aug 29, 2025
aelovikov-intel
approved these changes
Aug 29, 2025
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Failures are unrelated. fixed by #19933
|
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 11, 2025
…19921) Context creation was failing when sub-sub-devices were exposed, because the Level Zero adapter attempted to add multiple USM pools with identical descriptors. This occurred since, for the L0 backend, sub-sub-devices and their parent sub-devices share the same Level Zero device handle and should use the same USM pool. This PR resolves the issue by ensuring only devices with unique Level Zero handles are collected for USM pool creation, preventing duplicate pools. Additionally, this PR fixes an issue with an uninitialized `ur_device_partition_property_t` variable passed to UR. Previously, this could result in an unexpected value for `value.affinity_domain` when the property type was `UR_DEVICE_PARTITION_BY_CSLICE` resulting on error from adapter.
AlexeySachkov
added a commit
that referenced
this pull request
Sep 15, 2025
This is a cherry-pick of #19921 Context creation was failing when sub-sub-devices were exposed, because the Level Zero adapter attempted to add multiple USM pools with identical descriptors. This occurred since, for the L0 backend, sub-sub-devices and their parent sub-devices share the same Level Zero device handle and should use the same USM pool. This PR resolves the issue by ensuring only devices with unique Level Zero handles are collected for USM pool creation, preventing duplicate pools. Additionally, this PR fixes an issue with an uninitialized `ur_device_partition_property_t` variable passed to UR. Previously, this could result in an unexpected value for `value.affinity_domain` when the property type was `UR_DEVICE_PARTITION_BY_CSLICE` resulting on error from adapter. Patch-by: Artur Gainullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context creation was failing when sub-sub-devices were exposed, because
the Level Zero adapter attempted to add multiple USM pools with
identical descriptors. This occurred since, for the L0 backend,
sub-sub-devices and their parent sub-devices share the same Level Zero
device handle and should use the same USM pool.
This PR resolves the issue by ensuring only devices with unique Level Zero
handles are collected for USM pool creation, preventing duplicate pools.
Additionally, this PR fixes an issue with an uninitialized
ur_device_partition_property_tvariable passed to UR. Previously, thiscould result in an unexpected value for
value.affinity_domainwhen theproperty type was
UR_DEVICE_PARTITION_BY_CSLICEresulting on error fromadapter.