-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL][NFC] Clean up __imf_* delarations in sycl intel math header #20873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFC] Clean up __imf_* delarations in sycl intel math header #20873
Conversation
Signed-off-by: jinge90 <[email protected]>
I suggest we keep the first declaration and remove the second instead. |
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @bader |
bader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinge90, thanks. Nice clean-up.
LGTM with a couple of suggestions.
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @againull |
There are duplicates for _imf* declarations in sycl/builtins.hpp, this PR aims to remove them, the necessary declarations will be moved into sycl/ext/intel/math.hpp to make sycl builtins.hpp clean.
We also unify the style for _imf* declarations in sycl intel math header to move them close to where they are invoked.