[SYCL] Move SYCLLowerWGLocalMemoryPass from PipelineStart to OptimizerEarlyEPCallback #20892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rEarlyEPCallback Revert bede0e9: "[SYCL][SYCLLowerWGLocalMemoryPass] Remove implicit dependency on AlwaysInlinerPass and move to PipelineStart (intel#16356)" Motivation: * Cleaner than manually force-inlining. In general, we should rely on the pass pipeline's ordering for inlining. * bede0e9's rationale - "we can't assume the backend lowers the global after AlwaysInlinerPass" - no longer has use case after a pass re-ordering in downstream target. * OptimizerEarlyEPCallback is the first module pass callback after AlwaysInlinerPass. This was also proposed in intel#16347. Closes intel#16617
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
reviewed
Dec 15, 2025
Co-authored-by: Yury Plyakhin <[email protected]>
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
done |
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert bede0e9:
"[SYCL][SYCLLowerWGLocalMemoryPass] Remove implicit dependency on AlwaysInlinerPass and move to PipelineStart (#16356)"
Motivation:
Closes #16617