[SYCL][ABI-break] Remove deprecated register_alloc_mode kernel property
#20919
+73
−324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
force-pushed
the
abi/remove_reg_alloc_mode
branch
from
b3f4f0a to
132e815
Compare
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Dec 17, 2025
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
dpcpp-tools related changes lgtm
| MaximumSize = 48, | ||
| ZeroInit = 49, | ||
| FastLink = 50, | ||
| GRFSize = 9, |
Contributor
There was a problem hiding this comment.
can we remove enum values? Won't that result in ABI breaks?
I guess "tis the season" ??
Contributor
Author
There was a problem hiding this comment.
I removed the RegisterAllocMode. But GRFSize ones are in use.
cperkinsintel
approved these changes
Dec 17, 2025
sarnex
approved these changes
Dec 18, 2025
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.