[libspirv] refactor generic atomic builtin to use CLC functions #21017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation uses outdated function e.g. __sync_val_compare_and_swap.
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
approved these changes
Jan 13, 2026
Contributor
againull
left a comment
againull
left a comment
There was a problem hiding this comment.
sycl/test-e2e/WorkGroupMemory/reduction_lambda.cpp change lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation uses outdated function e.g. __sync_val_compare_and_swap.
Add new __spirv_AtomicFlagClear and __spirv_AtomicFlagTestAndSet builtins.
Add more variants of __spirv_AtomicIDecrement/AtomicIIncrement to libspirv-amdgcn--amdhsa.bc.
Test WorkGroupMemory/reduction_lambda.cpp now passes on native-cpu device.