[OVEP] Support for providing layout to input/output to OpenVINO #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatinwadhwa921
requested review from
sfatimar,
ankitm3k,
preetha-intel,
vthaniel and
n1harika
| @@ -828,6 +828,8 @@ select from 'TF8', 'TF16', 'UINT8', 'FLOAT', 'ITENSOR'. \n)"); | |||
| ov_options[key] = value; | |||
| } else if (key == "reshape_input") { | |||
| ov_options[key] = value; | |||
| } else if (key == "layout") { | |||
| ov_options[key] = value; | |||
There was a problem hiding this comment.
Should we then also update the THROW message?
ORT_THROW(
"[ERROR] [OpenVINO] wrong key type entered. Choose from the following runtime key options that are available for OpenVINO."
" ['device_type', 'device_id', 'num_of_threads', 'load_config', 'cache_dir', 'num_streams', "
"'enable_opencl_throttling', 'disable_dynamic_shapes', 'enable_qdq_optimizer',"
" 'enable_causallm', 'model_priority', 'layout'] \n");
| std::unordered_set<char> seen_alphabets; | ||
| for (char c : layout_str) { | ||
| if (std::isalpha(c)) { | ||
| char upper_c = std::toupper(c); // Convert to uppercase for case-insensitive comparison |
There was a problem hiding this comment.
Hope this helps. The following error occurred during Windows build:
error C2220: the following warning is treated as an error [...\onnxruntime\build\Windows\Release\onnxruntime_providers_openvino.vcxproj] ...\onnxruntime\onnxruntime\core\providers\openvino\openvino_parser_utils.cc(297,20): warning C4244: 'initializing': conversion from 'int' to 'char', possible loss of data
This change helped me fix the issue:
char upper_c = static_cast<char>(std::toupper(c));
|
@sfatimar, @preetha-intel hi! |
DariaMityagina
approved these changes
Aug 7, 2025
jatinwadhwa921
force-pushed
the
jatin_layout_feature
branch
from
915f153 to
57848b4
Compare
jatinwadhwa921
force-pushed
the
jatin_layout_feature
branch
from
57848b4 to
afa46ca
Compare
jatinwadhwa921
added
the
ovep_abi_1.0
vthaniel
pushed a commit
that referenced
this pull request
Aug 28, 2025
* [OVEP] Support for providing layout to input/output to OpenVINO * [OVEP] Minor bug fixes for layout feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new provider option that allows users to explicitly set the layout for model inputs and outputs
The layout can be configured using the following command-line format:
"N","C","H","W", or use"?"as a placeholder if the layout dimension is unknown.