create_perf_json: Expose PDIST Counter information in PublicDescription #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic PDIST availability information can only be found in the SDM. Also, some events may not support PDIST. It's hard to find that information either. Append the PDIST information into the PublicDescription of the event list, if it's available. If the event or platform doesn't support PDIST, nothing is changed. The PDIST Counter information may be useful for the hardware-aware grouping of Linux perf. But the hardware-aware grouping only works for perf stat for now. There is no plan to enable the hardware-aware grouping for perf record shortly. Adding a dedicated PDIST field is unnecessary. Signed-off-by: Kan Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic PDIST availability information can only be found in the SDM. Also, some events may not support PDIST. It's hard to find that information either.
Append the PDIST information into the PublicDescription of the event list, if it's available.
If the event or platform doesn't support PDIST, nothing is changed.
The PDIST Counter information may be useful for the hardware-aware grouping of Linux perf. But the hardware-aware grouping only works for perf stat for now. There is no plan to enable the hardware-aware grouping for perf record shortly. Adding a dedicated PDIST field is unnecessary.