Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Adding Louvain clustering algorithm support #1963

Draft
wants to merge 123 commits into
base: main
Choose a base branch
from

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Jul 26, 2024

Description

This exposes a cpu-only estimator with a previously unused oneDAL algorithm. Testing is ongoing, and an updated description will be added at a later date.

List issue number(s) if exist(s): #6 (for example)


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

@icfaust
Copy link
Contributor Author

icfaust commented Jul 31, 2024

Looks as though louvain uses an RNG but doesn't allow for external seed setting. I think that I will move this to the preview namespace because of all the bad behavior and possible memory leaks

@icfaust
Copy link
Contributor Author

icfaust commented Aug 9, 2024

Tire kick seems to work from sklearnex object, will now have to create tests on sklearnex side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant