Skip to content

Fix: Handle CNAME in Quad9 resolver and prevent DNS visualizer errors (#2959) #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix: Handle CNAME in Quad9 resolver and prevent DNS visualizer errors (#2959) #3005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
987765d
Merge pull request #2849 from intelowlproject/develop
drosetti May 20, 2025
bb1fa31
Fix Quad9 DNS resolver: handle A/AAAA/CNAME records properly to avoid…
Sep 18, 2025
8e38ac3
Fix: Quad9 DNS resolver retry logic and DNS visualizer key error
Sep 21, 2025
c8521c6
Fix: DNS visualizer handle missing/empty 'resolutions' (#2959)
Sep 27, 2025
cb540ef
Apply isort fixes to imports
Sep 27, 2025
0f8bb85
Implement Quad9DNSResolver with JSON response parsing
PranavShukla7 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions api_app/analyzers_manager/observable_analyzers/dns/dns_resolvers/quad9_dns_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"""Quad9 DNS resolutions"""
import logging

import dns.message
import httpx

from api_app.analyzers_manager import classes
Expand Down Expand Up @@ -35,21 +34,21 @@ def run(self):
# with 2 or 3 attemps the analyzer should get the data
attempt_number = 3
quad9_response = None
for attempt in range(0, attempt_number):
for attempt in range(attempt_number):
try:
quad9_response = httpx.Client(http2=True).get(
complete_url, headers=self.headers, timeout=10
)
except httpx.ConnectError as exception:
# if the last attempt fails, raise an error
if attempt == attempt_number - 1:
raise exception
else:
quad9_response.raise_for_status()

dns_response = dns.message.from_wire(quad9_response.content)
json_response = quad9_response.json()
resolutions: list[str] = []
for answer in dns_response.answer:
resolutions.extend([resolution.address for resolution in answer])
for answer in json_response.get("Answer", []):
if "data" in answer:
resolutions.append(answer["data"])

return dns_resolver_response(observable, resolutions)
5 changes: 2 additions & 3 deletions api_app/visualizers_manager/visualizers/dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from api_app.analyzers_manager.observable_analyzers.dns.dns_resolvers.quad9_dns_resolver import ( # noqa: E501
Quad9DNSResolver,
)
from api_app.choices import Classification
from api_app.models import Job
from api_app.visualizers_manager.classes import VisualizableObject, Visualizer
from api_app.visualizers_manager.decorators import (
Expand Down Expand Up @@ -68,8 +67,8 @@ def _dns_resolution(self, analyzer_report: AnalyzerReport) -> VisualizableObject
value=[
self.Base(
value=(
dns_resolution["data"]
if self._job.analyzable.classification == Classification.DOMAIN
dns_resolution.get("data")
if isinstance(dns_resolution, dict) and "data" in dns_resolution
else dns_resolution
),
disable=False,
Expand Down