Skip to content

Fixing UsersClient.View when searching with parameters #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SonnyCampbell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing UsersClient.View when searching with parameters #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions src/Intercom/Clients/UsersClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ public User View(Dictionary<String, String> parameters)
throw new ArgumentException("'parameters' argument should include user_id parameter.");
}

ClientResponse<User> result = null;
ClientResponse<Users> result = null;

result = Get<User>(parameters: parameters);
return result.Result;
result = Get<Users>(parameters: parameters);
return result.Result.users.FirstOrDefault();
}

public User View(String id)
Expand All @@ -141,28 +141,26 @@ public User View(User user)
}

Dictionary<String, String> parameters = new Dictionary<string, string>();
ClientResponse<User> result = null;

if (!String.IsNullOrEmpty(user.id))
{
result = Get<User>(resource: USERS_RESOURCE + Path.DirectorySeparatorChar + user.id);
}
else if (!String.IsNullOrEmpty(user.user_id))
return Get<User>(resource: USERS_RESOURCE + Path.DirectorySeparatorChar + user.id).Result;
}

if (!String.IsNullOrEmpty(user.user_id))
{
parameters.Add(Constants.USER_ID, user.user_id);
result = Get<User>(parameters: parameters);
return Get<Users>(parameters: parameters).Result.users.FirstOrDefault();
}
else if (!String.IsNullOrEmpty(user.email))

if (!String.IsNullOrEmpty(user.email))
{
parameters.Add(Constants.EMAIL, user.email);
result = Get<User>(parameters: parameters);
return Get<Users>(parameters: parameters).Result.users.FirstOrDefault();;
}
else
{
throw new ArgumentException("you need to provide either 'user.id', 'user.user_id', 'user.email' to view a user.");
}

return result.Result;

throw new ArgumentException("you need to provide either 'user.id', 'user.user_id', 'user.email' to view a user.");

}

public Users List()
Expand Down