feat: add filter for Spanish blog posts and style tweaks#143
Merged
ioana-chiorean merged 1 commit intomainfrom Jul 8, 2025
Merged
feat: add filter for Spanish blog posts and style tweaks#143ioana-chiorean merged 1 commit intomainfrom
ioana-chiorean merged 1 commit intomainfrom
Conversation
huijing
commented
Jul 8, 2025
| } | ||
|
|
||
| article :global(code) { | ||
| article :global(:not(pre) > code) { |
Contributor
Author
There was a problem hiding this comment.
There were some style changes due to the latest Starlight upgrade (see https://github.com/withastro/starlight/releases/tag/%40astrojs%2Fstarlight%400.34.0), this fixes that issue
ioana-chiorean
approved these changes
Jul 8, 2025
Contributor
ioana-chiorean
left a comment
ioana-chiorean
left a comment
There was a problem hiding this comment.
Awesome work HJ! thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
lang: eswill show up on that pageThis decision to not do a full-fledged i18n of the blog is because we will not be translating most of the blog posts, only a select few in preparation for the Summit and Hackathon, therefore the effort to properly i18n-ise the blog was not considered commensurate to the end result.
In future, if we want to fully invest in multilingual content, then we can consider implementing a complete i18n solution.