-
Notifications
You must be signed in to change notification settings - Fork 1
chore: adjust banner header font-size for better mobile fit #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I suggest we keep the smooth font scaling which is what we get with |
Completely agree, thank you I'd like to keep |
I will update headers that have hard coded sizes after this PR merges.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's change those font sizes on Drupal as you listed and check the hero banners for appropriate soft breaks as well then.
Ping me when you are ready so I can merge these changes on prod just before you make the hero banner font adjustments.
PR Checklist
Summary
Make heading font smaller on mobile, so text can fit better
Safari wasn't respecting the soft hyphens in the banners
Includes changes from PR 114 => closed PR