Skip to content

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Sep 24, 2025

Changes proposed in this pull request

  • Adds text during the consent screen to properly reference a subject information request.

Context

Closes RAF-997.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

Copy link

github-actions bot commented Sep 24, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 41.04
  • Iterations/s: 13.69
  • Failed Requests: 0.00% (0 of 2471)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 892 kB 15 kB/s
     data_sent......................: 1.9 MB 32 kB/s
     http_req_blocked...............: avg=6.33µs   min=2.51µs   med=5.3µs    max=476.92µs p(90)=6.5µs    p(95)=7µs     
     http_req_connecting............: avg=275ns    min=0s       med=0s       max=189.12µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=96.85ms  min=9.56ms   med=78.45ms  max=675.32ms p(90)=167.87ms p(95)=183.7ms 
       { expected_response:true }...: avg=96.85ms  min=9.56ms   med=78.45ms  max=675.32ms p(90)=167.87ms p(95)=183.7ms 
     http_req_failed................: 0.00%  ✓ 0         ✗ 2471
     http_req_receiving.............: avg=90.14µs  min=28.2µs   med=75.39µs  max=3.34ms   p(90)=110.38µs p(95)=138.11µs
     http_req_sending...............: avg=40.93µs  min=9.99µs   med=27.99µs  max=3.19ms   p(90)=40.86µs  p(95)=58.01µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=96.71ms  min=9.43ms   med=78.32ms  max=675.22ms p(90)=167.78ms p(95)=183.48ms
     http_reqs......................: 2471   41.044335/s
     iteration_duration.............: avg=292.05ms min=196.96ms med=277.67ms max=1.14s    p(90)=340.33ms p(95)=399.28ms
     iterations.....................: 824    13.686982/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@njlie njlie requested review from cozminu and mkurapov September 29, 2025 21:15
@cozminu cozminu marked this pull request as ready for review October 2, 2025 09:41
Copy link
Contributor

@cozminu cozminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
]
},
"subject": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a separate example folder that just has two requests, this one (with just the subject request), and the grant continuation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result, we should have the mock ASE be able to handle requests with just the subject field (without showing the 0 amount):

Screenshot 2025-10-06 at 14 00 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants