feat(background): store spent amount on payment to retrieve balance #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: background
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
commented
Jul 2, 2024
Shows up fine in Setting screen
Rest of UI do be done under #378 |
sidvishnoi
requested review from
raducristianpopa and
dianafulga
and removed request for
raducristianpopa
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #272.
Changes proposed in this pull request
Saves
grantSpentDebitAmountas "amountSpent" in storage, which we can later use to retrieve balance. To handle race conditions, we store the max of amount spent in the batch of multiple (possibly parallel) calls.Extracted from #379, but using throttling instead of debouncing.