fix(background): better error message for connectWallet
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidvishnoi
changed the title
github-actions
bot
added
the
area: background
sidvishnoi
changed the title
connectWallet
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
commented
Jul 5, 2024
| @@ -23,5 +23,8 @@ | |||
| }, | |||
| "siteNotMonetized": { | |||
| "message": "This website is not monetized." | |||
| }, | |||
| "error_connectWallet_invalidClient": { | |||
There was a problem hiding this comment.
Looking into this convention for future:
error_*for error messagesaction_*for button/link actionsstate_*mostly everything else- and rest can be anything I guess?
Can't use / or . or : unfortunately.
There was a problem hiding this comment.
I would suggest error_openPayments_invalidClient for this.
There was a problem hiding this comment.
I was not going for openPayments here as this error is specific to one we show during connect wallet. When it happens during payment (openPayments_invalidClient again), we go for "key revoked" state which has its own error messages. We might show a different one during reconnectWallet even.
sidvishnoi
commented
Jul 5, 2024
sidvishnoi
force-pushed
the
connect-wallet-address
branch
from
4ca8a3d
to
0585d57
Compare
sidvishnoi
commented
Jul 5, 2024
dianafulga
approved these changes
Jul 5, 2024
| @@ -23,5 +23,8 @@ | |||
| }, | |||
| "siteNotMonetized": { | |||
| "message": "This website is not monetized." | |||
| }, | |||
| "error_connectWallet_invalidClient": { | |||
There was a problem hiding this comment.
I would suggest error_openPayments_invalidClient for this.
Co-authored-by: Radu-Cristian Popa <[email protected]>
raducristianpopa
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of #147
Changes proposed in this pull request