Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MonetizationLinkManager): monetize single link tag in iframes #949

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix(MonetizationLinkManager): monetize single link tag in iframes #949

wants to merge 13 commits into from

Conversation

DarianM
Copy link
Member

@DarianM DarianM commented Mar 1, 2025 •
edited
Loading

Context #921

DarianM and others added 13 commits February 14, 2025 00:37
@DarianM
replace onAdded/onRemoved
198d7b2
@DarianM
cache promises; single source of truth
92f73f3
@DarianM
cache validateLink instead of checkLink
a6f5ff7
@DarianM
use weakset instead of promise caching
9bfe58c
@sidvishnoi
Merge branch 'main' (early part) into 920-simplify-monetization-link-…
f5a3fe0 
…detection-and-handling
@DarianM @sidvishnoi
test(MonetizationLinkManager): add unit tests for link detection (#929)
88cdb8e 
Co-authored-by: Sid Vishnoi <[email protected]>
@sidvishnoi @DarianM
fix(keyAutoAdd): abort if user navigates to some other website (#943)
b29752a
@DarianM
Merge branch 'main' into 920-simplify-monetization-link-detection-and…
cdc1d85 
…-handling
@DarianM
fix dynamically added monetization link test
a7de5e7
@DarianM
pass first batch of tests; main frame
c85a48d
@DarianM
early return
f81b9e9
@DarianM
Merge branch '920-simplify-monetization-link-detection-and-handling' …
a103e4a 
…into 921-one-single-monetization-link-in-iframes
@DarianM
monetize only first tag in iframe
218144e
@DarianM DarianM linked an issue Mar 1, 2025 that may be closed by this pull request
At any time allow one single monetization link in iframes #921
Open
@github-actions github-actions bot added area: content Improvements or additions to extension content script area: tests Improvements or additions to tests labels Mar 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

Extension builds preview

Name Link
Latest commit 218144e
Latest job logs Run #13606904256
BadgeDownload
BadgeDownload

@DarianM DarianM changed the title 921 one single monetization link in iframes fix(MonetizationLinkManager): monetization single link tag in iframes Mar 1, 2025
@DarianM DarianM changed the title fix(MonetizationLinkManager): monetization single link tag in iframes fix(MonetizationLinkManager): monetize single link tag in iframes Mar 1, 2025
@DarianM DarianM requested a review from sidvishnoi March 1, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi Awaiting requested review from sidvishnoi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: content Improvements or additions to extension content script area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

At any time allow one single monetization link in iframes
2 participants
@DarianM @sidvishnoi