Switch ExtractorPDF and ExtractorPDFContent to pdfbox #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtractorPDF is using a very old version of itext from 2006. Updating it to the newer version of itext used in contrib would require distribution of core Heritrix to come under the AGPL.
Apache PDFBox is Apache 2 licensed, is actively maintained and used by other widely adopted tools like Apache Tika. So this PR changes both PDF extractors to use the latest version of PDFBox instead.
Neither extractor is enabled by the default configuration so this likely doesn't affect many users.