Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat manifest hops same as navlink hops #623

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kris-sigur
Copy link
Collaborator

Links from manifests (e.g. sitemaps) should not receive the preferential treatment sometimes accorded to "transitive" hops. Most commonly this is about giving priority to discovered (probable) embeds.

Manifests should be regarded as more analogous with a directory page.

Links from manifests (e.g. sitemaps) should not receive the preferential
treatment sometimes accorded to "transitive" hops. Most commonly this is
about giving priority to discovered (probable) embeds.

Manifests should be regarded as more analogous with a directory page.
@kris-sigur
Copy link
Collaborator Author

I suppose, alternatively (or additionally), the logic in FrontierPreparer#getSchedulingDirective could be amended to schedule M links ahead of L, but after E X R etc.

This seams a slightly more invasive change as it would require either adding a level or moving current "HIGH" to "HIGHEST" and current "MEDIUM" to "HIGH" to free up "MEDIUM" priority for manifests. Given that "HIGHEST" priority doesn't seem to be used anywhere, maybe this isn't much of an issue. The alternative would be to add a priority level constant, if we want to leave "HIGHEST" available.

If this approach is taken, Inferred links should maybe also be treated at this 'middle' level.

@ato
Copy link
Collaborator

ato commented Nov 11, 2024

I actually wonder if sitemap links should even be de-prioritised compared to the normal link structure because they effectively flatten the structure of the site. If a big site happens to put all their leaf pages at the beginning, which is very common because they're often the most recently updated articles that they want search engines to pick up, the crawl might miss important intermediate section pages that in a non-sitemap crawl would have priority because of being less deep.

Copy link
Collaborator

@ato ato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yes, this is at least an improvement on the current situation.

@ato ato merged commit 29cc045 into internetarchive:master Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants