expand solr query escape flow to include single quotes #7931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Works like a charm! https://testing.openlibrary.org/search?q=Cornell+%2777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7618
I have expanded the
fully_escaped_queryfunction to include queries with single quotes.Technical
Please note that this is a temporary fix for now as the luqum parser should be accepting single quote characters in the first place. I will try to make a PR on the https://github.com/jurismarches/luqum repo for this issue.
Testing
This following query should no longer have an error:
https://openlibrary.org/search?q=Cornell+%2777%3A+The+Music%2C+the+Myth+and+the+Magnificence+of+the+Grateful+Dead+Show+at+Barton+Hall&mode=everything
Screenshot
No longer facing
IllegalCharacterErrorStakeholders
@cdrini