Skip to content

fix max function usage on list of feature_weights_list #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix max function usage on list of feature_weights_list #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dice_ml/explainer_interfaces/dice_genetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def do_loss_initializations(self, yloss_type, diversity_loss_type, feature_weigh
feature_weights_list.append(feature_weights[feature])
else:
# the weight is inversely proportional to max value
feature_weights_list.append(round(1 / self.feature_range[feature].max(), 2))
feature_weights_list.append(round(1 / max(self.feature_range[feature]), 2))
self.feature_weights_list = [feature_weights_list]

def do_random_init(self, num_inits, features_to_vary, query_instance, desired_class, desired_range):
Expand Down